Skip to content

Allow TypeSpec project path to be a github link#13517

Merged
smw-ms merged 10 commits intoAzure:mainfrom
smw-ms:create-rp-link-url
Jan 21, 2026
Merged

Allow TypeSpec project path to be a github link#13517
smw-ms merged 10 commits intoAzure:mainfrom
smw-ms:create-rp-link-url

Conversation

@smw-ms
Copy link
Member

@smw-ms smw-ms commented Jan 9, 2026

Resolves: #13488

Copilot AI review requested due to automatic review settings January 9, 2026 20:57
@smw-ms smw-ms requested a review from a team as a code owner January 9, 2026 20:57
@github-actions github-actions bot added the azsdk-cli Issues related to Azure/azure-sdk-tools::tools/azsdk-cli label Jan 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for using GitHub URLs as TypeSpec project paths in addition to local filesystem paths. The implementation allows users to reference TypeSpec projects directly via URLs like https://github.com/Azure/azure-rest-api-specs/blob/main/specification/service/Service.Management.

Key changes:

  • Added URL validation for GitHub spec repository URLs with pattern matching
  • Extended core TypeSpec helper methods to detect and handle URL inputs
  • Enhanced management plane detection to infer from URL path patterns when config files aren't accessible
  • Comprehensive test coverage for URL-based operations

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Helpers/TypeSpecHelper.cs Added URL detection and validation logic, extended existing methods to handle both local paths and GitHub URLs
tools/azsdk-cli/Azure.Sdk.Tools.Cli.Tests/Helpers/TypeSpecHelperTests.cs Added comprehensive test cases for URL validation, management plane detection, and path operations with URLs
tools/azsdk-cli/Azure.Sdk.Tools.Cli.Tests/Tools/ReleasePlan/ReleasePlanToolTests.cs Replaced mock TypeSpecHelper with real implementation and added integration test using GitHub URL

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

@smw-ms smw-ms merged commit 16edd37 into Azure:main Jan 21, 2026
12 checks passed
JennyPng pushed a commit to JennyPng/azure-sdk-tools that referenced this pull request Jan 22, 2026
* Allow TypeSpec project path to be a github link

* Add url check for IsRepoPathForSpecRepo method

* Update Changelog

* Respond to copilot

* Seperate into url specific helper functions

* Add extra url parse test

* Respond to copilot comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azsdk-cli Issues related to Azure/azure-sdk-tools::tools/azsdk-cli

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create release plan MCP tool needs to verify TypeSpec project path

4 participants